Add support for compiler-managed CFSTR() on non-Darwin systems #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test with this pull request: @swift-ci please test |
compnerd
reviewed
Oct 27, 2018
|
Please test with this pull request: @swift-ci please test |
compnerd
approved these changes
Oct 27, 2018
|
Please test with this pull request: @swift-ci please test |
|
Ready to merge whenever the clang change is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the swift-corelibs-foundation implementation closer to the Darwin implementation by making the compiler lay out constant CFStrings produced by CFSTR(). It requires a corresponding clang patch to work.
This is only enabled for not-
TARGET_OS_MACfor now, since the clang used to build Swift here is not the same as the one used by Xcode when using a Swift toolchain. When Xcode gets the new clang, we can enable this forTARGET_OS_MACas well.rdar://42898576