Fix linkage for Linux and BSD symbol declarations that use CF_PRIVATE
#1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols using `CF_PRIVATE` are meant to be available outside the compilation unit where they're declared, but not outside Core Foundation. Headers that use `CF_PRIVATE` thus mean to declare, not define, these symbols. Match Darwin by adding `extern` to the `CF_PRIVATE` definition, and then add `-fno-common` to also match how Darwin compiles and detect double symbol definitions. This fixes Linux crashes in CFString encoding introduced by the Mojave merge.
|
@compnerd ping. CMake flag addition incoming. |
|
@swift-ci please test |
|
LGTM, I do believe that this should fix the issue as the types were marked with |
|
@swift-ci please test |
|
Thank you @compnerd for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols using
CF_PRIVATEare meant to be available outside the compilation unit where they're declared, but not outside Core Foundation. Headers that useCF_PRIVATEthus mean to declare, not define, these symbols. Match Darwin by addingexternto theCF_PRIVATEdefinition, and then add-fno-commonto also match how Darwin compiles and detect double symbol definitions.This fixes Linux crashes in CFString encoding introduced by the Mojave merge.