build: compatibility for CMake 3.4.3 #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3.4.3 does not support the copy files... <directory> pattern. Add compatibility for it.
|
@swift-ci please test |
|
NOTE: The linux test here will be on 16.04 machine, so it will have a newer cmake. I am testing this locally to be sure this works on 14.04 with cmake-3.4.3. |
|
Got through to that weird XCTest that fails sometime. But we got through all of the foundation tests where we were failing. |
|
Reran skipping the earlier tests and XCTest passed. I think we need to increase the timeout on that test. |
|
Merging to unbreak the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.4.3 does not support the copy files... pattern. Add
compatibility for it.