Skip to content

build: remove the custom build system #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 5, 2018

Encouragement for people to move to CMake as the one build system for
Swift!

Encouragement for people to move to CMake as the one build system for
Swift!
@gottesmm
Copy link
Contributor

gottesmm commented Nov 5, 2018

So beautiful...

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

@swift-ci please clean test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

CC: @millenomi

@millenomi
Copy link
Contributor

As part of removing this, we must document how to build Core Foundation standalone, since the previous instructions I had relied on the old build system.

Do you have any indications on how to invoke CMake correctly to build CF with CF_DEPLOYMENT_SWIFT off?

@compnerd
Copy link
Member Author

compnerd commented Nov 8, 2018

@millenomi - if you have the exact configuration you would like to build, I should be able to tweak the build to get that build working.

@spevans
Copy link
Contributor

spevans commented Nov 10, 2018

I think Docs/GettingStarted.md needs an update as to how to invoke the tests now that ninja test doesn't work since build.ninja is in the build directory.

@spevans
Copy link
Contributor

spevans commented Nov 23, 2018

@swift-ci please test

@spevans
Copy link
Contributor

spevans commented Feb 11, 2020

@compnerd Now that there is a separate PR for updating the docs (#2657) do you want to resurrect this one and finally remove the old build system?

@compnerd
Copy link
Member Author

Yeah, I can do that soonish. Im neck deep in Foundation debugging right now, and don't want to page that out

@shahmishal shahmishal closed this Oct 6, 2020
@shahmishal
Copy link
Member

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants