CoreFoundation: use #include instead of #import #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @millenomi @phausler |
|
@swift-ci please test |
phausler
reviewed
Nov 6, 2018
`#import` when building for Windows will be treated as the import of a type library rather than the semantics of Objective-C style `#import` which does an include once type of operation. Convert to the `#include` syntax instead to allow this to be built on Windows as well (e.g. via clang-cl).
compnerd
force-pushed
the
include-import-shuffle
branch
from
3324cd5 to
34854e2
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#importwhen building for Windows will be treated as the import of atype library rather than the semantics of Objective-C style
#importwhich does an include once type of operation. Convert to the
#includesyntax instead to allow this to be built on Windows as well (e.g. via
clang-cl).