Return Self instead of UnitLength in UnitLength override method #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes “cannot override a Self return type with a non-Self return type” error.
|
@swift-ci test |
|
@swift-ci test |
|
@tkremenek This changed because the default is now -swift-version 5 right? Should we just be passing -swift-version 4 instead? |
|
We want to be on the latest version of the language as much as possible. |
|
@swift-ci please test |
|
I'm going to try and address this problem when moving to Swift 5 with a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes “cannot override a Self return type with a non-Self return type” error in Swift 5 compiler.