Decimal: Fix .doubleValue to use _length to only index valid mantissa elements. #1759
+98
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test linux |
This was referenced Jun 24, 2019
xwu
added a commit
to swiftlang/swift
that referenced
this pull request
Jun 25, 2019
* Update Decimal.swift Fix `Decimal.magnitude` so that `Decimal.nan.magnitude` is no longer incorrectly `0`. Port changes from swiftlang/swift-corelibs-foundation#1759, crucially correcting an error where `(0 as Decimal).doubleValue` returned `.nan`. * [gardening] Zap indentation error * Add test for `Decimal.nan.magnitude` * Apply reviewer suggestion Clean up `doubleValue`
millenomi
pushed a commit
that referenced
this pull request
Nov 11, 2020
* Update Decimal.swift Fix `Decimal.magnitude` so that `Decimal.nan.magnitude` is no longer incorrectly `0`. Port changes from #1759, crucially correcting an error where `(0 as Decimal).doubleValue` returned `.nan`. * [gardening] Zap indentation error * Add test for `Decimal.nan.magnitude` * Apply reviewer suggestion Clean up `doubleValue`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://forums.swift.org/t/severe-decimal-error-in-foundation-on-linux-needs-workaround/14359/6