Skip to content

Mark subclasses of Dimension final. #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Mark subclasses of Dimension final. #1761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4c3fb
Mark subclasses of Dimension final.
tkremenek Nov 13, 2018
4148d8b
Add back 'public' access level to Dimension subclasses.
tkremenek Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions Foundation/Unit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ open class Dimension : Unit {
}
}

open class UnitAcceleration : Dimension {
public final class UnitAcceleration : Dimension {

/*
Base unit - metersPerSecondSquared
Expand Down Expand Up @@ -297,7 +297,7 @@ open class UnitAcceleration : Dimension {
}
}

open class UnitAngle : Dimension {
public final class UnitAngle : Dimension {

/*
Base unit - degrees
Expand Down Expand Up @@ -378,7 +378,7 @@ open class UnitAngle : Dimension {
}
}

open class UnitArea : Dimension {
public final class UnitArea : Dimension {

/*
Base unit - squareMeters
Expand Down Expand Up @@ -523,7 +523,7 @@ open class UnitArea : Dimension {
}
}

open class UnitConcentrationMass : Dimension {
public final class UnitConcentrationMass : Dimension {

/*
Base unit - gramsPerLiter
Expand Down Expand Up @@ -578,7 +578,7 @@ open class UnitConcentrationMass : Dimension {
}
}

open class UnitDispersion : Dimension {
public final class UnitDispersion : Dimension {

/*
Base unit - partsPerMillion
Expand Down Expand Up @@ -619,7 +619,7 @@ open class UnitDispersion : Dimension {
}
}

open class UnitDuration : Dimension {
public final class UnitDuration : Dimension {

/*
Base unit - seconds
Expand Down Expand Up @@ -676,7 +676,7 @@ open class UnitDuration : Dimension {
}
}

open class UnitElectricCharge : Dimension {
public final class UnitElectricCharge : Dimension {
/*
Base unit - coulombs
*/
Expand Down Expand Up @@ -756,7 +756,7 @@ open class UnitElectricCharge : Dimension {
}
}

open class UnitElectricCurrent : Dimension {
public final class UnitElectricCurrent : Dimension {

/*
Base unit - amperes
Expand Down Expand Up @@ -830,7 +830,7 @@ open class UnitElectricCurrent : Dimension {
}
}

open class UnitElectricPotentialDifference : Dimension {
public final class UnitElectricPotentialDifference : Dimension {

/*
Base unit - volts
Expand Down Expand Up @@ -904,7 +904,7 @@ open class UnitElectricPotentialDifference : Dimension {
}
}

open class UnitElectricResistance : Dimension {
public final class UnitElectricResistance : Dimension {

/*
Base unit - ohms
Expand Down Expand Up @@ -978,7 +978,7 @@ open class UnitElectricResistance : Dimension {
}
}

open class UnitEnergy : Dimension {
public final class UnitEnergy : Dimension {

/*
Base unit - joules
Expand Down Expand Up @@ -1052,7 +1052,7 @@ open class UnitEnergy : Dimension {
}
}

open class UnitFrequency : Dimension {
public final class UnitFrequency : Dimension {

/*
Base unit - hertz
Expand Down Expand Up @@ -1149,7 +1149,7 @@ open class UnitFrequency : Dimension {
}
}

open class UnitFuelEfficiency : Dimension {
public final class UnitFuelEfficiency : Dimension {

/*
Base unit - litersPer100Kilometers
Expand Down Expand Up @@ -1206,7 +1206,7 @@ open class UnitFuelEfficiency : Dimension {
}
}

open class UnitLength : Dimension {
public final class UnitLength : Dimension {

/*
Base unit - meters
Expand Down Expand Up @@ -1415,7 +1415,7 @@ open class UnitLength : Dimension {
}
}

open class UnitIlluminance : Dimension {
public final class UnitIlluminance : Dimension {

/*
Base unit - lux
Expand Down Expand Up @@ -1456,7 +1456,7 @@ open class UnitIlluminance : Dimension {
}
}

open class UnitMass : Dimension {
public final class UnitMass : Dimension {

/*
Base unit - kilograms
Expand Down Expand Up @@ -1617,7 +1617,7 @@ open class UnitMass : Dimension {
}
}

open class UnitPower : Dimension {
public final class UnitPower : Dimension {

/*
Base unit - watts
Expand Down Expand Up @@ -1738,7 +1738,7 @@ open class UnitPower : Dimension {
}
}

open class UnitPressure : Dimension {
public final class UnitPressure : Dimension {

/*
Base unit - newtonsPerMetersSquared (equivalent to 1 pascal)
Expand Down Expand Up @@ -1851,7 +1851,7 @@ open class UnitPressure : Dimension {
}
}

open class UnitSpeed : Dimension {
public final class UnitSpeed : Dimension {

/*
Base unit - metersPerSecond
Expand Down Expand Up @@ -1916,7 +1916,7 @@ open class UnitSpeed : Dimension {
}
}

open class UnitTemperature : Dimension {
public final class UnitTemperature : Dimension {

/*
Base unit - kelvin
Expand Down Expand Up @@ -1979,7 +1979,7 @@ open class UnitTemperature : Dimension {
}
}

open class UnitVolume : Dimension {
public final class UnitVolume : Dimension {

/*
Base unit - liters
Expand Down