Skip to content

isEqual needs to be declared public in final classes. #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018
Merged

isEqual needs to be declared public in final classes. #1767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Foundation/Unit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ public final class UnitAcceleration : Dimension {
return .metersPerSecondSquared
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitAcceleration else {
return false
}
Expand Down Expand Up @@ -365,7 +365,7 @@ public final class UnitAngle : Dimension {
return .degrees
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitAngle else {
return false
}
Expand Down Expand Up @@ -510,7 +510,7 @@ public final class UnitArea : Dimension {
return .squareMeters
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitArea else {
return false
}
Expand Down Expand Up @@ -565,7 +565,7 @@ public final class UnitConcentrationMass : Dimension {
return UnitConcentrationMass.gramsPerLiter
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitConcentrationMass else {
return false
}
Expand Down Expand Up @@ -606,7 +606,7 @@ public final class UnitDispersion : Dimension {
return .partsPerMillion
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitDispersion else {
return false
}
Expand Down Expand Up @@ -663,7 +663,7 @@ public final class UnitDuration : Dimension {
return .seconds
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitDuration else {
return false
}
Expand Down Expand Up @@ -743,7 +743,7 @@ public final class UnitElectricCharge : Dimension {
return .coulombs
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitElectricCharge else {
return false
}
Expand Down Expand Up @@ -817,7 +817,7 @@ public final class UnitElectricCurrent : Dimension {
return .amperes
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitElectricCurrent else {
return false
}
Expand Down Expand Up @@ -891,7 +891,7 @@ public final class UnitElectricPotentialDifference : Dimension {
return .volts
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitElectricPotentialDifference else {
return false
}
Expand Down Expand Up @@ -965,7 +965,7 @@ public final class UnitElectricResistance : Dimension {
return .ohms
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitElectricResistance else {
return false
}
Expand Down Expand Up @@ -1039,7 +1039,7 @@ public final class UnitEnergy : Dimension {
return .joules
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitEnergy else {
return false
}
Expand Down Expand Up @@ -1136,7 +1136,7 @@ public final class UnitFrequency : Dimension {
return .hertz
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitFrequency else {
return false
}
Expand Down Expand Up @@ -1193,7 +1193,7 @@ public final class UnitFuelEfficiency : Dimension {
return .litersPer100Kilometers
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitFuelEfficiency else {
return false
}
Expand Down Expand Up @@ -1402,7 +1402,7 @@ public final class UnitLength : Dimension {
return .meters
}

open override func isEqual(_ object: Any?) -> Bool {
public override func isEqual(_ object: Any?) -> Bool {
guard let other = object as? UnitLength else {
return false
}
Expand Down