Windows Port #1779
Closed
Windows Port #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify the behaviour across macOS and Linux, FreeBSD to use
pthread_mutex_t when CFLock is used. This will allow us to remove
references to pthread_mutex_{lock,unlock} which makes CoreFoundation
easier to port to Windows.
Replace some pthread_mutex_lock and pthread_mutex_unlock with __CFLock and __CFUnlock respectively. Replace instances of pthread_mutex_t with __CFLock. This reduces the explicit dependency on pthread, permitting porting CoreFoundation to other theading models (e.g. Windows).
This allows CF to be built for windows. The dependencies are curl, icu, and libxml2.
|
Superseded by #1783. The patches have been formalized and extended. They can still deal with a bit of clean up, but I think that there is no longer any value in this reference work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes allows building for windows. There are some implementations and some things which can be cleaned up, but, this at least identifies the areas that we need to fix up.