build: copy static/shared library support from libdispatch #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Update SwiftSupport.cmake from libdispatch for the shared/static library work tht I did there.
The dependencies may be empty which will fail. Guard against that.
compnerd
force-pushed
the
static-shared-library
branch
from
5d3321d to
68ae32f
Compare
|
@swift-ci please test and merge |
Use the `DEPENDS` keyword argument to `add_swift_*` instead of the explicit `add_dependencies`.
compnerd
force-pushed
the
static-shared-library
branch
from
68ae32f to
d457d6a
Compare
|
@swift-ci please test and merge |
We expect to generate the shared library right now. In preparation to build static libraries as well, enable the shared build by default.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SwiftSupport.cmake from libdispatch for the shared/static library work
tht I did there.