JSONSerialization: fix a crash when an escape sequence contains low-surrogate code point without the corresponding high-surrogate code point #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jakepetroules
previously requested changes
Dec 12, 2018
broadwaylamb
force-pushed
the
master
branch
2 times, most recently
from
08d08da to
c1fae7b
Compare
|
@swift-ci test |
|
@spevans can you please re-trigger the build? Seems like it's stuck. |
|
@swift-ci test |
|
@jakepetroules is there anything else I can improve in this PR? |
|
LGTM, but please have @itaiferber review as well. |
itaiferber
approved these changes
Dec 14, 2018
…urrogate code point without the corresponding high-surrogate code point
|
@swift-ci Please test and merge |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The triggering JSON:
[ "\uDFF3" ]I've also added some tests. However, I couldn't run them, because the test suite crashes on this line:
https://github.com/apple/swift-corelibs-foundation/blob/b5d216e2ef7299faed12f404654f1f514eb8138a/TestFoundation/HTTPServer.swift#L581
And I have no idea why, but pretty sure my fix has nothing to do with it.
(In fact, in order to build TestFoundation, I needed to dance around a bit, because the
xdgTestHelpertarget requires Swift 3 compatibility mode, which is not supported in the latest development snaphsot that I've been using.)