Windows Port Continuation #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace instances of raw `pthread_t` with `_CFThreadRef` to prepare for the Windows threading support.
Update the type definitions to use the native windows threading primitives on Windows targets
Windows does not use POSIX threads. We emulate some of the behaviours. The thread handle type on Windows is `HANDLE` rather than `pthread_t`. Use the invalid handle instead to indicate that we do not have the value yet.
On Windows, there is no `pthread_self`. Duplicate and leak the handle for the main thread. Since this is a global singleton, the overhead should be fine.
Define _CFThreadCreate in terms of _beginthreadex on Windows rather than pthread_create.
|
@swift-ci please test |
Use _binaryLoadable to ensure that the path exists rather than _urlExists.
Remove the error condition that no longer applies to the current code.
Add an assertion to ensure that we do not truncate the thread reference.
|
@swift-ci please test |
millenomi
approved these changes
Dec 14, 2018
|
I'm late on this one, but re: the C11 thing - we use it for Darwin, and I'm ok with it here, assuming that all our target platforms support it. I didn't think VS had C11 support but happy to hear I'm wrong on that, if so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces some of the threading types to allow us to use the Windows threading model rather than POSIX threads. This is still incomplete, but these should also be pretty safe without changing the semantics for the other platforms.