Use bundled UUID #1819
Merged
Use bundled UUID #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
Add support for building the bundled UUID library. This ensures that the UUID behaviours are the same across the different environments and is needed for supporting Windows which uses some of the UUID APIs which are not available.
Rather than relying on the system UUID, use the bundled UUID on all the targets. There is some work needed to port this to windows, but this should be sufficient for Linux (and FreeBSD).
This adjusts the UUID code to build on Windows which is needed for the Foundation port itself.
|
CC: @millenomi @parkera |
|
Why not just use CoCreateGuid instead of adding the libuuid dependency? |
|
@jakepetroules - because there are auxiliary functions here that need to be re-implemented then. The conversion to from string can be done using Win32 APIs, but, it seems that if we do this, we can avoid the dependency on e2fsprogs on Linux as well. Its a pretty tiny code base, already here, and means that all the ports have the same code base. (Note that I did use |
parkera
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup the build to build the bundled UUID and port to windows in preparation for supporting Windows as a build target.