Skip to content

SR-9550: xdgURLs assumes home directory location for .userDirectory #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

SR-9550: xdgURLs assumes home directory location for .userDirectory #1823

merged 1 commit into from
Feb 1, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Jan 15, 2019

  • Parse /etc/default/useradd to find the default home directory,
    falling back to /home.

@spevans
Copy link
Contributor Author

spevans commented Jan 15, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jan 15, 2019

cc @compnerd

compnerd
compnerd approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@compnerd
Copy link
Member

@swift-ci please test

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Jan 16, 2019

@swift-ci please test

@spevans
SR-9550: xdgURLs assumes home directory location for .userDirectory
9a0609b 
- Parse /etc/default/useradd to find the default home directory,
  falling back to /home.
@spevans
Copy link
Contributor Author

spevans commented Jan 19, 2019

@swift-ci please test

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Jan 19, 2019

@swift-ci please test

@spevans spevans requested a review from millenomi January 23, 2019 12:55
@millenomi
Copy link
Contributor

@swift-ci please test and merge

2 similar comments
@spevans
Copy link
Contributor Author

spevans commented Feb 1, 2019

@swift-ci please test and merge

@spevans
Copy link
Contributor Author

spevans commented Feb 1, 2019

@swift-ci please test and merge

@swift-ci swift-ci merged commit 480caee into swiftlang:master Feb 1, 2019
@spevans spevans mentioned this pull request Jan 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spevans @compnerd @millenomi @swift-ci