Skip to content

SR-9685: Accessing NSNumber(value: 1.2 as Float).description crashes #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2019
Merged

SR-9685: Accessing NSNumber(value: 1.2 as Float).description crashes #1830

merged 2 commits into from
Jan 28, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Jan 17, 2019

  • NSNumber.description: Second kCFNumberFloatType should have been
    kCFNumberFloat32Type in case statement.

  • Remove extra kCFNumberCGFloatType as it is handled seperately.

@spevans
Copy link
Contributor Author

spevans commented Jan 17, 2019

@swift-ci test

parkera
parkera approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome set of additional tests.

@spevans
Copy link
Contributor Author

spevans commented Jan 17, 2019

Just testing that ICU is built on the CI tests, I dont think it is at the moment

@spevans
Copy link
Contributor Author

spevans commented Jan 17, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jan 17, 2019

@shahmishal Which preset is used when running CI tests for swift-corelibs-foundation ?
From the log for the test for this PR @ https://ci.swift.org/view/Pull%20Request/job/swift-corelibs-foundation-PR-Linux/1730/consoleFull I see --skip-build-libicu is being passed means the ICU repository isnt being built so the latest version isnt used causing the tests to fail.

@spevans
Copy link
Contributor Author

spevans commented Jan 27, 2019

@swift-ci test

@spevans
SR-9685: Accessing NSNumber(value: 1.2 as Float).description crashes
7d02aec 
- NSNumber.description: Second kCFNumberFloatType should have been
  kCFNumberFloat32Type in case statement.

- Remove extra kCFNumberCGFloatType as it is handled seperately.
@spevans
Copy link
Contributor Author

spevans commented Jan 28, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jan 28, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jan 28, 2019

@swift-ci test and merge

@spevans
Copy link
Contributor Author

spevans commented Jan 28, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jan 28, 2019

@swift-ci test and merge

@swift-ci swift-ci merged commit 1375de0 into swiftlang:master Jan 28, 2019
@spevans spevans mentioned this pull request Jan 17, 2019
Closed
@spevans spevans mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkera parkera parkera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spevans @parkera @swift-ci