Improve flags handling for Windows build #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rpath handling uses linker flags specific to the ELF linkers. This is in preparation to build for Windows which does does not have the concept of `DT_RPATH`.
Adjust the CFLAGS to indicate that the shared CRT is used since we do not support the static CRT as that makes the DLL unusable with other executables as the shared and static CRT cannot be mixed in a single address space. The flag itself does not collide on other targets (at least currently). If necessary, that can be made target dependent.
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the flags handling to enable building for the Windows target which does not support
-rpathand requires an indication that the shared C library is being used.