Foundation: use numericCast in places for LLP64
#1833
Merged
+31
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLP64 causes the `Int` type to be different on LLP64 hosts and LP64 as Swift does not have `intptr_t`. This prepares for some of those changes by using `numericCast` to hide the type checks.
|
@swift-ci please test |
|
So, we talked at length about this. There are assumptions in the compiler that make Int 32-bit on Windows to facilitate C interop, and they're harder to reverse than just touching the few spots where C interop is using different types than on LP32/LP64. The Foundation interface will remain unaffected. If Windows port maintenance is able to catch any leaking of Int that needs cast and propose patches (e.g. via CI), I'm okay pulling those in as things happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLP64 causes the
Inttype to be different on LLP64 hosts and LP64 asSwift does not have
intptr_t. This prepares for some of those changesby using
numericCastto hide the type checks.