Skip to content

Convert RunLoopMode to RunLoop.Mode as with Darwin Foundation #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Jan 19, 2019

This also needs changes on XCTest side.

@ikesyo
Copy link
Member Author

ikesyo commented Jan 19, 2019

Please test with the following pull request:
swiftlang/swift-corelibs-xctest#241

@swift-ci test

1 similar comment
@ikesyo
Copy link
Member Author

ikesyo commented Jan 19, 2019

Please test with the following pull request:
swiftlang/swift-corelibs-xctest#241

@swift-ci test

@ikesyo
Copy link
Member Author

ikesyo commented Jan 24, 2019

/cc @parkera

The PR for XCTest is already approved.

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikesyo ikesyo merged commit 5f20cf6 into swiftlang:master Jan 25, 2019
@ikesyo ikesyo deleted the make-runloopmode-nested branch January 25, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants