Skip to content

port NSLock to Windows #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019
Merged

port NSLock to Windows #1843

merged 1 commit into from
Jan 24, 2019

Conversation

compnerd
Copy link
Member

This is the NSLock specific bits of the Windows port. It is dependent on a previous change (#1842), but, this at least splits up the change into a digestible change.

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Implement NSLock semantics for Windows in terms of CONDITION_VARIABLE
and SRWLOCK.
@compnerd
Copy link
Member Author

(rebased)

@compnerd
Copy link
Member Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit a8a5e78 into swiftlang:master Jan 24, 2019
@compnerd compnerd deleted the locking branch January 24, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants