Skip to content

Remove redundant modifiers to address the warnings #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions TestFoundation/TestNSAttributedString.swift
Original file line number Diff line number Diff line change
Expand Up @@ -296,19 +296,19 @@ class TestNSAttributedString : XCTestCase {

fileprivate extension TestNSAttributedString {

fileprivate func describe(range: NSRange) -> String {
func describe(range: NSRange) -> String {
return "(\(range.location),\(range.length))"
}

fileprivate func describe(attr: Any?) -> String {
func describe(attr: Any?) -> String {
if let attr = attr {
return "\(attr)" + "|"
} else {
return "nil" + "|"
}
}

fileprivate func describe(attrs: [NSAttributedStringKey : Any]) -> String {
func describe(attrs: [NSAttributedStringKey : Any]) -> String {
if attrs.count > 0 {
let mapped: [String] = attrs.map({ "\($0.rawValue):\($1)" })
let sorted: [String] = mapped.sorted(by: { $0 < $1 })
Expand Down
4 changes: 2 additions & 2 deletions TestFoundation/TestOperationQueue.swift
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class AsyncOperation: Operation {
private var _executing = false
private var _finished = false

override internal(set) var isExecuting: Bool {
override var isExecuting: Bool {
get {
lock.lock()
let wasExecuting = _executing
Expand All @@ -221,7 +221,7 @@ class AsyncOperation: Operation {
}
}

override internal(set) var isFinished: Bool {
override var isFinished: Bool {
get {
lock.lock()
let wasFinished = _finished
Expand Down
2 changes: 1 addition & 1 deletion TestFoundation/TestXMLDocument.swift
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ class TestXMLDocument : LoopbackServerTest {
}

fileprivate extension XMLNode {
fileprivate func findFirstChild(named name: String) -> XMLNode? {
func findFirstChild(named name: String) -> XMLNode? {
guard let children = self.children else {
return nil
}
Expand Down