Foundation: port FileHandle to Windows #1848
Conversation
|
@swift-ci please test |
compnerd
force-pushed
the
handle-with-care
branch
from
db3b697 to
d47fba0
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
handle-with-care
branch
from
d47fba0 to
0f81ff1
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
handle-with-care
branch
from
0f81ff1 to
ccd5a8b
Compare
This ports the FileHandle interfaces to Windows.
compnerd
force-pushed
the
handle-with-care
branch
from
ccd5a8b to
1c331c1
Compare
|
@swift-ci please test |
| @@ -22,6 +22,10 @@ import CoreFoundation | |||
|
|
|||
| @_exported import Dispatch | |||
|
|
|||
| #if os(Windows) | |||
| import WinSDK | |||
There was a problem hiding this comment.
Where did we end up on this? Will this cause people importing Foundation to also get WinSDK?
There was a problem hiding this comment.
Yeah, I think that currently it does currently result in WinSDK getting pulled in, since we do not yet have the private import (I think that @jrose-apple was working on the that?). If there is a way to avoid that, I'm happy to try that out. I don't think that going with Shims for this is very good though because as we start using more interfaces across Windows, we will effectively end up re-creating the SDK.
There was a problem hiding this comment.
It's probably reasonable in the end; on Darwin it's not like you can't help but import standard Darwin headers if you import Foundation.
|
@parkera - so is this good to go then? |
|
Looks good to me - thanks! |
This ports the FileHandle interfaces to Windows.