Skip to content

Update NSKeyedArchiver.swift #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jan 26, 2019
Merged

Update NSKeyedArchiver.swift #1851

merged 1 commit into from Jan 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2019

Why can't we use an if let?

@ikesyo
Copy link
Member

ikesyo commented Jan 25, 2019

@swift-ci Please test

ikesyo
ikesyo approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! 👍

@ghost
Copy link
Author

ghost commented Jan 25, 2019 •
edited by ghost
Loading

There are a lot of these if x != nil { x! }. Why can't we write a simple script to remove them all? So that they become:

if let x = x {
  x
}

@ikesyo ikesyo merged commit f753b1c into swiftlang:master Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikesyo