Foundation: port NSThread to Windows #1856
Conversation
|
CC: @phausler @parkera @millenomi @spevans @jakepetroules |
|
@swift-ci please test |
compnerd
force-pushed
the
thread-the-needle
branch
from
10dde71 to
080918a
Compare
|
@swift-ci please test |
|
@jrose-apple - suggestions as to what may be the cause of the deserialization issue? |
|
Does SwiftFoundation on Mac use the system CoreFoundation? |
|
It better not be using the system CF. The layout of the objects are different (and we have functions with differing signatures etc) |
|
Hm, good point. We probably would have noticed that a long time ago. Maybe the CoreFoundation overlay is causing problems? Do we need a SwiftCoreFoundation? |
|
@phausler agreed ... that would be really bad, right, I didn't consider that (sorry, dealing with Linux, Android, and Windows a lot atm, so keep forgetting that Darwin has CF there) |
|
Or is _CFThreadRef only defined when certain macros are passed? If that's the case, it can't be used in a stored property (yet). |
|
_CFThreadRef is only defined in the SCLF version of CF. The Darwin CF does not have such a notion.(also that typedef is private anyhow) |
|
Woah, I think @phausler is on to something ... I think that it is using the system CF. This is not in the Foundation build, but in XCTest. |
|
Hmm, could it be a difference between the Xcode and the CMake build? It seems from the jenkins build that this is being invoked from xcodebuild. |
renaming it to SwiftCoreFoundation has other issues that crop up. We tried that early on in the initial bring-up of SCLF. It failed pretty horribly then, but perhaps with alot of work it could be done now that things are not so much in flux as they were back then? |
compnerd
force-pushed
the
thread-the-needle
branch
from
080918a to
72010af
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
thread-the-needle
branch
from
72010af to
6d9aa9b
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
thread-the-needle
branch
from
6d9aa9b to
a285671
Compare
|
@swift-ci please test |
Implement the Thread interfaces for Windows. Extend the CoreFoundation interface to support thread stack reservation sizing.
The compiler is working hard to keep the type sugar on the interface for even an internal interface. The type sugar being preserved causes a deserialization failure on Darwin. Use an equivalent local typealias to avoid the issue. SR-9811
compnerd
force-pushed
the
thread-the-needle
branch
from
a285671 to
f5fb8fe
Compare
|
@swift-ci please test and merge |
Implement the Thread interfaces for Windows. Extend the CoreFoundation
interface to support thread stack reservation sizing.