NSString: sync with overlay #1861
Merged
+2,084
−2,051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Why does corelibs-foundation contain another copy of a file from Swift that needs to be kept in sync? |
|
We don't currently have a way to share the sources between the two git repos. The build scenarios would be very complicated. |
parkera
approved these changes
Jan 29, 2019
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time,
NSStringAPI.swifthas diverged from the overlay. Bring it back in sync.Most of these changes are whitespace, but there are important functional changes included, like the port of swiftlang/swift@a088e13 which adds fastpaths for
Data->Stringconversions.The diff with whitespace removed is +79 −46. You can hide whitespace changes on GitHub using the "Diff settings" dropdown in the Files changed tab.