Skip to content

Foundation: sundry fixes for Windows port #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

compnerd
Copy link
Member

Adjust the source for LLP64 (Windows x64/AArch64) and account for
non-POSIX environment. Collect them into a single change as they are
small enough to not be a problem to really inspect in a single batch.

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

Adjust the source for LLP64 (Windows x64/AArch64) and account for
non-POSIX environment.  Collect them into a single change as they are
small enough to not be a problem to really inspect in a single batch.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

Hmm, @spevans you've been helpful with the windows changes too :-)

@jakepetroules
Copy link
Contributor

Looks generally fine to me

Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here seem reasonable to me

@compnerd compnerd merged commit d1510fd into swiftlang:master Jan 31, 2019
@compnerd compnerd deleted the collection branch January 31, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants