Fix a bug in format localized number on s390x #1871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Foundation test on s390x, there is a warning:
The debugging shows
(disableLocalizedFormatting == -1)
is nevertrue
becausedisableLocalizedFormatting
is defined aschar
, and then the logic of format localized number is not correct on s390x.Changing
disableLocalizedFormatting
toshort
to make the logic works on all platforms