CoreFoundation: fix CoreFoundation for Foundation static builds #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreFoundation built statically for Foundation is used as an objects library. We want to re-export the symbols. This requires that exports are enabled for the target, but CMake defines _EXPORT symbols only for shared libraries and `-rdynamic` executables. Use the custom macro for the static case for Foundation.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreFoundation built statically for Foundation is used as an objects
library. We want to re-export the symbols. This requires that exports
are enabled for the target, but CMake defines _EXPORT symbols only for
shared libraries and
-rdynamicexecutables. Use the custom macro forthe static case for Foundation.