Skip to content

Foundation: update index -> firstIndex (NFCI) #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2019
Merged

Foundation: update index -> firstIndex (NFCI) #1881

merged 1 commit into from
Feb 5, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Feb 4, 2019

Update a few instances of index to firstIndex as per the deprecation
warnings. NFCI

@compnerd
Foundation: update index -> firstIndex (NFCI)
125825b 
Update a few instances of `index` to `firstIndex` as per the deprecation
warnings.  NFCI
@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2019

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2019

CC: @mikeash @itaiferber @parkera @phausler @millenomi

@mikeash
Copy link
Contributor

mikeash commented Feb 4, 2019

LGTM.

@itaiferber
Copy link
Contributor

I'll let @millenomi comment, but LGTM as well

@millenomi millenomi merged commit bcc12c8 into swiftlang:master Feb 5, 2019
@compnerd compnerd deleted the first branch February 5, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compnerd @mikeash @itaiferber @millenomi