[4.2] SR-8560: XMLDocument on Linux crashes with a Segmentation Fault #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When returning an XMLNode, take a reference to the parent XMLDocument to prevent the underlying libxml xml document from being freed. - This prevents the document being freed if a reference is still held to a XMLNode but not the XMLDocument. (cherry picked from commit aabed33)
|
@swift-ci test 4.2 |
|
@kevints Another XML crash fix. |
ianpartridge
reviewed
Feb 7, 2019
| <plans></plans> | ||
| """ | ||
|
|
||
| let data = str.data(using: .utf8)! |
There was a problem hiding this comment.
It doesn't matter for this PR, but let data = Data(str.utf8) is nicer as there's no optional involved.
There was a problem hiding this comment.
Yes, definitely need a cleanup of the tests in master at some point.
adam-fowler
added a commit
to adam-fowler/soto-core
that referenced
this pull request
Jul 2, 2019
- This fixes a crash most likely related to swiftlang/swift-corelibs-foundation#1887 We need to ensure we hold a reference to the XMLDocument if we are processing XMLNodes inside it. I've done this by allowing Body to hold an XMLDocument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning an XMLNode, take a reference to the parent
XMLDocument to prevent the underlying libxml xml document
from being freed.
This prevents the document being freed if a reference is still
held to a XMLNode but not the XMLDocument.
(cherry picked from commit aabed33)