[4.2] SR-7455: Allow NUL in Strings to match Darwin #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- String._conditionallyBridgeFromObjectiveC: Use String(decoding:as: UTF8.self) instead of String(cString:) to allow NULs in the decoded string. - Update tests which use buffers with trailing zeros to create strings, making the tests work correctly against Darwin's native Foundation. (cherry picked from commit 860956a)
- If CFStringGetLength() returns 0 just create an empty string ("").
- Try CFStringGetCharactersPtr() before CFStringGetCharacters()
to avoid allocating a buffer.
(cherry picked from commit 666c8c4)
- Add tests for multibyte UTF-8/ UTF-16. (cherry picked from commit 8422c1a)
|
String bridging fix. |
|
@swift-ci test 4.2 |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String._conditionallyBridgeFromObjectiveC:
Use String(decoding:as: UTF8.self) instead of String(cString:) to allow NULs in the decoded string.
Update tests which use buffers with trailing zeros to create strings,
making the tests work correctly against Darwin's native Foundation.
(cherry picked from commit 860956a)
If CFStringGetLength() returns 0 just create an empty string ("").
Try CFStringGetCharactersPtr() before CFStringGetCharacters()
to avoid allocating a buffer.
(cherry picked from commit 666c8c4)
(cherry picked from commit 8422c1a)