Skip to content

[4.2] NSIndexPath: Make compatible with Darwin. #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Feb 8, 2019

  • init(indexes:length:): Fix method signatue and allow nil pointer
    with 0 length to match Darwin.

  • Implement copy(with:)

  • Mark getIndex(_:range:) as unavailable (deprecated in Darwin).

(cherry picked from commit c0bac19)

- init(indexes:length:): Fix method signatue and allow nil pointer
  with 0 length to match Darwin.

- Implement copy(with:)

- Mark getIndex(_:range:) as unavailable (deprecated in Darwin).

(cherry picked from commit c0bac19)
@spevans
Copy link
Contributor Author

spevans commented Feb 8, 2019

@swift-ci test 4.2

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Feb 9, 2019

@swift-ci test 4.2

@spevans
Copy link
Contributor Author

spevans commented Feb 11, 2019

cc @kevints @weissi

Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @spevans , lgtm!

@weissi weissi merged commit dc6ecd6 into swiftlang:swift-4.2-branch Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants