Skip to content

[4.2] SR-9828: JSONEncoder keyEncodingStrategy does not work on Linux #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2019
Merged

[4.2] SR-9828: JSONEncoder keyEncodingStrategy does not work on Linux #1892

merged 1 commit into from
Feb 11, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Feb 9, 2019

  • Implement .convertToSnakeCase key encoding.

(cherry picked from commit c0feda6)

@spevans
SR-9828: JSONEncoder keyEncodingStrategy does not work on Linux
bbc5485 
- Implement .convertToSnakeCase key encoding.

(cherry picked from commit c0feda6)
@spevans
Copy link
Contributor Author

spevans commented Feb 9, 2019

@swift-ci test 4.2

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Feb 9, 2019

@swift-ci test 4.2

@spevans
Copy link
Contributor Author

spevans commented Feb 11, 2019

cc @kevints @weissi

weissi
weissi approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @spevans , lgtm

@weissi weissi merged commit 310b0d9 into swiftlang:swift-4.2-branch Feb 11, 2019
@swift-ci swift-ci mentioned this pull request Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spevans @weissi