[4.2] SR-7608: Pipe() crashes when the underlying system call fails. #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Objective-C, the fileHandleFor{Reading,Writing} property is mutable even on a
const instance. Change the property to read/write.
(cherry picked from commit 09cfc21)
- Pipe does not have a failable or throwable initializer but currently calls fatalError() for all errors returned from pipe(). - If pipe() returns EMFILE or ENFILE then set the fileDescriptor to -1 for both .fileHandleForReading and .fileHandleForWriting. For all other errors call fatalError(). - TestFileHandle.swift: Remove duplicate test_pipe(). - TestPipe.swift: Add extra test to try and exhaust the process's pipes. - Test the file descriptor is valid and open for certain methods and properties to match Darwin. (cherry picked from commit 870d425)
|
@swift-ci test 4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe does not have a failable or throwable initializer but currently
calls fatalError() for all errors returned from pipe().
If pipe() returns EMFILE or ENFILE then set the fileDescriptor
to -1 for both .fileHandleForReading and .fileHandleForWriting.
For all other errors call fatalError().
TestFileHandle.swift: Remove duplicate test_pipe().
TestPipe.swift: Add extra test to try and exhaust the process's pipes.
Test the file descriptor is valid and open for certain methods
and properties to match Darwin.
(cherry picked from commit 870d425)
NSPipe: make fileHandleFor{Reading,Writing} mutable
(cherry picked from commit 09cfc21)