Skip to content

[4.2] Decimal: Fix .doubleValue to use _length to only index valid mantissa elements. #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

[4.2] Decimal: Fix .doubleValue to use _length to only index valid mantissa elements. #1900

merged 1 commit into from
Feb 13, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Feb 12, 2019

(cherry picked from commit 54a29e2)

@spevans
Copy link
Contributor Author

spevans commented Feb 12, 2019

@swift-ci test 4.2

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Feb 12, 2019

@swift-ci test 4.2

@spevans spevans requested a review from weissi February 12, 2019 22:20
@millenomi
Copy link
Contributor

@weissi if okay for you, LGTM for 4.x.

weissi
weissi approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks

@weissi weissi merged commit 430bdf0 into swiftlang:swift-4.2-branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spevans @millenomi @weissi