[4.2] FileManager: setAttributes(ofItemAtPath:) should throw if chmod fails. #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- chmod() failing should throw an error and not call fatalError(). - Behaviour now matches Darwin. (cherry picked from commit 5995272)
spevans
force-pushed
the
pr_set_attributes_chmod_42
branch
from
b5544e8 to
1712f5b
Compare
|
@swift-ci test 4.2 |
parkera
approved these changes
Feb 13, 2019
|
cc @weissi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chmod() failing should throw an error and not call fatalError().
Behaviour now matches Darwin.
(cherry picked from commit 5995272)