[5.0] NSDecimalValue: Dont use .doubleValue for integer properties. #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decimal: Add an internal .int64Value and .uint64Value. - NSDecimalValue: For the .int*Value and .uint*Value properties use a truncated value from .int64Value and .uint64Value. - Using .doubleValue lost information when returning large numbers > 2e53 due to Double to Int conversion. - The returned values mostly match Darwin, moreso than just returning 0 when an exact conversion cannot be made. (cherry picked from commit f369d31)
|
@swift-ci test |
parkera
approved these changes
Feb 14, 2019
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decimal: Add an internal .int64Value and .uint64Value.
NSDecimalValue: For the .intValue and .uintValue properties
use a truncated value from .int64Value and .uint64Value.
Using .doubleValue lost information when returning large numbers
The returned values mostly match Darwin, moreso than just returning 0
when an exact conversion cannot be made.
(cherry picked from commit f369d31)