Supported Scanner API for Swift #1914
Conversation
|
@swift-ci please test |
|
@swift-ci Please test source compatibility |
|
… worth a try. |
|
@shahmishal is it possible to set up 'please test source compatibility' for s-c-f? |
| } | ||
|
|
||
| public func scanInt(representation: NumberRepresentation = .decimal) -> Int? { | ||
| #if arch(x86_64) || arch(arm64) || arch(s390x) || arch(powerpc64) || arch(powerpc64le) |
There was a problem hiding this comment.
Would it be better to write this as if Int.bitWidth == Int64.bitWidth to avoid having to maintain a list of archs?
There was a problem hiding this comment.
We use this in Data as well just to save the runtime check.
There was a problem hiding this comment.
Wouldnt it be a constant expression and optimised away by the compiler?
There was a problem hiding this comment.
There were issues with that IIRC, and it may or may not be.
|
I bet the issue with the test is that one of the emoji isn't recognized as an emoji by ICU 61. |
| var value = Int32.max | ||
| switch representation { | ||
| case .decimal: guard self.scanInt32(&value) else { return nil } | ||
| default: |
There was a problem hiding this comment.
should this be case .hexadecimal instead of .default ?
|
Are |
|
@millenomi because of https://bugs.swift.org/browse/SR-9699 the CI tests arent even building ICU so might be worth getting it fixed now ;) |
|
|
||
| // Overflow: | ||
| withScanner(for: "\(Int64.max)0") { | ||
| expectEqual($0.scanInt64(), Int64.max, "Overflow") |
There was a problem hiding this comment.
So is there anyway to detect if a number being scanned is >Int64.max ? Or have a flag to say dont clip to Int64.max ?
There was a problem hiding this comment.
It can't not clip to a Int64 value, since it returns a Int64. This is consistent with the behavior of the older methods.
|
@spevans it is indeed https://bugs.swift.org/browse/SR-9699 — I pinged @shahmishal about it. |
|
|
||
| // On overflow, the below methods will return success and clamp | ||
| @discardableResult | ||
| open func scanInt32(_ result: UnsafeMutablePointer<Int32>) -> Bool { |
There was a problem hiding this comment.
Am I misreading the Scanner documentation or should all of these scanXXX(_ result: UnsafeMutablePointer<XXX>) -> Bool methods actually take an optional pointer?
https://developer.apple.com/documentation/foundation/scanner/1410914-scanint32
Looks like they may have always been wrong?
There was a problem hiding this comment.
Yeah, good catch. I'll follow up to correct the signatures.
Yes, can you file a Jira bug? |
|
@swift-ci test |
Add API on Scanner that's more idiomatic for use in Swift. This promotes some of the existing experimental API and deprecates the rest. The new API is intended to operate on graphemes, not single UTF-16 code units. This API is not experimental and will be supported going forward.