Foundation: fix a couple of compile errors #1916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoundationErrors does not depend on NSSwiftRuntime and thus does not transitively get the WinSDK import when not building in whole program mode. Add an import to get a definition of `DWORD`. Remoe the `private(set)` from the computed `processIdentifier` property which is already readonly due to the definition of the computed property.
|
@swift-ci please test |
phausler
approved these changes
Feb 15, 2019
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FoundationErrors does not depend on NSSwiftRuntime and thus does not
transitively get the WinSDK import when not building in whole program
mode. Add an import to get a definition of
DWORD.Remoe the
private(set)from the computedprocessIdentifierpropertywhich is already readonly due to the definition of the computed
property.