Skip to content

[5.0] URLSessionTask: implement InputStream. #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 29, 2019
Merged

[5.0] URLSessionTask: implement InputStream. #1932

merged 14 commits into from
Mar 29, 2019

Conversation

albertaleksieiev
Copy link
Contributor

@albertaleksieiev albertaleksieiev commented Feb 21, 2019 •
edited
Loading

Allows using InputStream in URLRequest as httpBodyStream. Also, implement seekInputStream in NativeProtocol.

This is a cherry-pick of the #1629

@albertaleksieiev
Copy link
Contributor Author

@ianpartridge can you please trigger a CI, thanks!

@ianpartridge
Copy link
Contributor

@swift-ci test

@millenomi
Copy link
Contributor

@ianpartridge good to merge?

millenomi
millenomi suggested changes Feb 25, 2019
View reviewed changes
@millenomi
Copy link
Contributor

I have to request a change in tests, but LGTM otherwise if @ianpartridge is okay with the implementation.

@albertaleksieiev
Copy link
Contributor Author

Thanks for your review @millenomi, I'll fix it ASAP 👍

@spevans
Copy link
Contributor

spevans commented Feb 27, 2019

@swift-ci test

1 similar comment
@spevans
Copy link
Contributor

spevans commented Feb 28, 2019

@swift-ci test

@spevans spevans changed the title URLSessionTask: implement InputStream. Swift-5 [5.0] URLSessionTask: implement InputStream. Feb 28, 2019
@albertaleksieiev
Copy link
Contributor Author

@millenomi please check my latest changes, thanks!

@spevans
Copy link
Contributor

spevans commented Mar 7, 2019

@millenomi is this ok to merge now?

@albertaleksieiev
Copy link
Contributor Author

@millenomi is this good now after my changes?

@millenomi
Copy link
Contributor

cc @ianpartridge I'm going to take this barring significant issues; let me know if we need a revert.

@albertaleksieiev do you have a PR for master?

@millenomi millenomi merged commit a9649e5 into swiftlang:swift-5.0-branch Mar 29, 2019
@hyouuu hyouuu mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millenomi millenomi millenomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albertaleksieiev @ianpartridge @millenomi @spevans