Skip to content

[5.0] SR-6531: FileManager copyItem() does not preserve permissions #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2019
Merged

[5.0] SR-6531: FileManager copyItem() does not preserve permissions #1935

merged 2 commits into from
Feb 25, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Feb 22, 2019 

- Use fchmod() to set the file permissions after opening.
  • Ensure all file permissions are correctly masked using ~S_IFMT.

(cherry picked from commit aa5f75c)

  • Check the file copy worked in the tests

(cherry picked from commit a16c18c)

@spevans
SR-6531: FileManager copyItem() does not preserve permissions
e297bbc 
- Use fchmod() to set the file permissions after opening.

- Ensure all file permissions are correctly masked using ~S_IFMT.

(cherry picked from commit aa5f75c)
@spevans
SR-6531: Check the file copy worked in the tests
7716988 
(cherry picked from commit a16c18c)
@spevans
Copy link
Contributor Author

spevans commented Feb 22, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Feb 25, 2019

@swift-ci test and merge

@swift-ci swift-ci merged commit 9383d7a into swiftlang:swift-5.0-branch Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spevans @swift-ci