Skip to content

build: link in dependencies on Windows #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2019
Merged

build: link in dependencies on Windows #1938

merged 1 commit into from
Feb 23, 2019

Conversation

compnerd
Copy link
Member

This sets up the dependencies we need on Windows. It helps reduce the
spew from the linker when building for windows.

@compnerd
build: link in dependencies on Windows
f4dcc0b 
This sets up the dependencies we need on Windows.  It helps reduce the
spew from the linker when building for windows.
@compnerd compnerd requested a review from gwynne February 23, 2019 00:03
@compnerd
Copy link
Member Author

CC: @millenomi @phausler @parkera @jakepetroules

@compnerd
Copy link
Member Author

@swift-ci please test

gwynne
gwynne approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit 8488657 into swiftlang:master Feb 23, 2019
@compnerd compnerd deleted the all-the-libraries branch February 23, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @gwynne