Foundation: remove deprecated bzero
#1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bzero` implementation is unnecessary as it is trivially implementable by the "modern" `memset` API. Additionally, the use of the type `size_t` causes trouble for Windows which tries to interpret it as `Foundation.size_t` rather than `ucrt.size_t` which results in a horrific deserialisation fatalError.
|
CC: @gwynne @millenomi |
|
@swift-ci please test |
gwynne
approved these changes
Feb 23, 2019
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bzeroimplementation is unnecessary as it is triviallyimplementable by the "modern"
memsetAPI. Additionally, the use ofthe type
size_tcauses trouble for Windows which tries to interpret itas
Foundation.size_trather thanucrt.size_twhich results in ahorrific deserialisation fatalError.