Skip to content

[5.0] Implement DateIntervalFormatter. #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Feb 27, 2019

(cherry picked from commit 988d5f8)

Add the new files to the CMakeLists.txts.

(cherry picked from commit 0eed327)

Fix boundary styles outside of Darwin.

(cherry picked from commit ff070d6)

Guard the tests as well.

(cherry picked from commit 32cfcf1)

Make tests fuzzier so they work on both Darwin and Linux ICUs.

(cherry picked from commit b342e5f)

Better assertion failure messages in the fuzzy matching.

(cherry picked from commit 0c69d1a)

Even more info.

(cherry picked from commit e395327)

Actually fix all the missed copy-paste changes after fuzzification.

(cherry picked from commit 1600080)

(cherry picked from commit 988d5f8)

Add the new files to the `CMakeLists.txt`s.

(cherry picked from commit 0eed327)

Fix boundary styles outside of Darwin.

(cherry picked from commit ff070d6)

Guard the tests as well.

(cherry picked from commit 32cfcf1)

Make tests fuzzier so they work on both Darwin and Linux ICUs.

(cherry picked from commit b342e5f)

Better assertion failure messages in the fuzzy matching.

(cherry picked from commit 0c69d1a)

Even more info.

(cherry picked from commit e395327)

Actually fix all the missed copy-paste changes after fuzzification.

(cherry picked from commit 1600080)
@spevans
Copy link
Contributor Author

spevans commented Feb 27, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Feb 27, 2019

cc @millenomi @ianpartridge

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 3d91e0b into swiftlang:swift-5.0-branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants