HACK: make FileHandle build on Windows again #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @millenomi |
millenomi
reviewed
Mar 1, 2019
| @@ -888,6 +893,10 @@ extension FileHandle { | |||
| } | |||
|
|
|||
| open func acceptConnectionInBackgroundAndNotify(forModes modes: [RunLoop.Mode]?) { | |||
| #if os(Windows) | |||
There was a problem hiding this comment.
Since this is for treating fds like sockets, it's fine if this is unavailable on Windows only.
compnerd
force-pushed
the
incase-of-emergency-glue-the-window
branch
from
9ead37b to
f0b6b10
Compare
|
@swift-ci please test |
A SOCKET is not a file descriptor on Windows which means that the shared implementation does not work for Windows. This allows us to build again. It should be possible to provide a special constructor that takes a SOCKET rather than a fd and wait on that though, so for now, use NSUnimplemented to guard that path.
compnerd
force-pushed
the
incase-of-emergency-glue-the-window
branch
from
f0b6b10 to
fc0f8d6
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readability and writability handlers are not yet implemented on
windows, and cannot be assigned to. A SOCKET is not a file descriptor
on Windows which means that the shared implementation does not work for
Windows.