Skip to content

[4.2] SR-7481: NumberFormatter inconsistency on Linux #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Mar 6, 2019

  • For the numberStyle .currency, use a minimumIntegerDigits of 1.

  • If minimumIntegerDigits is set to any value (including 0) before
    the numberStyle is set, preserve the original value.

(cherry picked from commit c8c16eb)

NumberFormatter: More fixes for numberStyles

  • Fix rawValue for Style.{currencyISOCode,currencyPlural,currencyAccounting}

  • Fix minimumIntegerDigits for .currencyPlural

  • Fix usesSignificantDigits, minimumIntegerDigits and groupingSize for
    .percent

(cherry picked from commit 3fef3a8)

spevans added 2 commits March 6, 2019 19:52
- For the numberStyle .currency, use a minimumIntegerDigits of 1.

- If minimumIntegerDigits is set to any value (including 0) before
  the numberStyle is set, preserve the original value.

(cherry picked from commit c8c16eb)
- Fix rawValue for Style.{currencyISOCode,currencyPlural,currencyAccounting}

- Fix minimumIntegerDigits for .currencyPlural

- Fix usesSignificantDigits, minimumIntegerDigits and groupingSize for
  .percent

(cherry picked from commit 3fef3a8)
@spevans
Copy link
Contributor Author

spevans commented Mar 6, 2019

@swift-ci test 4.2

@spevans spevans requested a review from weissi March 6, 2019 21:45
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@weissi weissi merged commit ff9b072 into swiftlang:swift-4.2-branch Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants