Skip to content

[5.0] Fix off-by-one when initializing Data with discontiguous, underestimated Sequences #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

[5.0] Fix off-by-one when initializing Data with discontiguous, underestimated Sequences #1996

merged 1 commit into from
Mar 13, 2019

Conversation

itaiferber
Copy link
Contributor

What's in this pull request?
Cherry-picks #1995 to swift-5.0-branch

@itaiferber itaiferber requested a review from phausler March 13, 2019 13:40
@itaiferber
Copy link
Contributor Author

@swift-ci Please test

@itaiferber itaiferber force-pushed the 5.0-data-underestimated-sequence-initializer-fix branch from b789fc8 to 081da03 Compare March 13, 2019 15:55
@itaiferber
Copy link
Contributor Author

Tests were cherry-picked from main Swift repo and were using expectEqual instead of XCTAssertEqaul. Fixed

@itaiferber
Copy link
Contributor Author

@swift-ci Please test

@itaiferber
Copy link
Contributor Author

@swift-ci Please test

@itaiferber itaiferber merged commit fbba490 into swiftlang:swift-5.0-branch Mar 13, 2019
@itaiferber itaiferber deleted the 5.0-data-underestimated-sequence-initializer-fix branch March 13, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itaiferber @phausler