Skip to content

TestFoundation: remove mkstemp usage #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

compnerd
Copy link
Member

mkstemp is not available on Windows. Replace the two sites with a
GUID temporary path instead.

@compnerd
Copy link
Member Author

CC: @millenomi @spevans

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd force-pushed the security-through-obscurity branch from f4bcebd to a656070 Compare March 15, 2019 00:00
@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@spevans spevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get rid of unnecessary helper functions

@compnerd
Copy link
Member Author

@swift-ci please test

4 similar comments
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2019

@swift-ci please test

@compnerd compnerd force-pushed the security-through-obscurity branch from a656070 to 7c3ef96 Compare April 12, 2019 21:57
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

`mkstemp` is not available on Windows.  Replace the two sites with a
GUID temporary path instead.
@compnerd compnerd force-pushed the security-through-obscurity branch from 7c3ef96 to e53af5a Compare April 17, 2019 20:28
@compnerd
Copy link
Member Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 92bbdd1 into swiftlang:master Apr 17, 2019
@compnerd compnerd deleted the security-through-obscurity branch April 17, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants