NumberFormatter: Get properties as attributes #2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
millenomi
suggested changes
Mar 18, 2019
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
- Re-enable TestNumberFormatter.test_en_US_initialValues()
- Also remove Number Formatter Styles constants defined only for macOS.
spevans
force-pushed
the
pr_number_formatter_properties
branch
from
f124427 to
0a9dc6e
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci please test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
millenomi
approved these changes
Mar 29, 2019
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable TestNumberFormatter.test_en_US_initialValues()
Convert internal ivars to private
Also remove Number Formatter Styles constants defined only for macOS.