Foundation: initialize CFSocket on startup #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
spevans
reviewed
Mar 20, 2019
Windows requires the networking subsystem (WinSock) to be initialized. However, the user expects to be able to use the networking APIs in Foundation without performing any one-time initialization. Furthermore, due to the macro usage in the initialization path, it is easier to perform the initialization in C than in Swift. CoreFoundation has a SPI for this (`__CFSocketInitializeWinSock`).
compnerd
force-pushed
the
prepare-to-be-networked
branch
from
17218cd to
d6f351f
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows requires the networking subsystem (WinSock) to be initialized.
However, the user expects to be able to use the networking APIs in
Foundation without performing any one-time initialization. Furthermore,
due to the macro usage in the initialization path, it is easier to
perform the initialization in C than in Swift. CoreFoundation has a SPI
for this (
__CFSocketInitializeWinSock).